Controller can handle dynamic strength range and levels of distortions. Bugfix for batched images forward warping call. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vipulSharma18
force-pushed
the
vipul/flexibleController
branch
from
9bfb763
to
26c012f
Compare
|
Great, possible to create a little associated test to be sure we don't have this problem in the future ? :) |
Hello! If we're talking about the bug fix for batched images, yep, I'll create one. Maybe I'll add it to this or a new PR if this one is already closed by the time I do the changes. |
|
I let you add the test and "rebase & merge" ! :) |
vipulSharma18
force-pushed
the
vipul/flexibleController
branch
from
9ee7d18
to
6df368c
Compare
…m input of range. Make the forward transform work for batched images (issue 7)
vipulSharma18
force-pushed
the
vipul/flexibleController
branch
from
d4bae1c
to
c766c43
Compare
|
Added test cases for batched input in base.py WarpTransform and all the possible scenarios of using WarpController in controller.py. Also made the code coverage tool work for pytest-cov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flexible controller:
The controller can now handle any number of distortion levels by sampling that many points from the hardcoded range of strength. It can also handle a user-defined range of strength values.
Batched images support: Fix for #7