Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home work 3 #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Home work 3 #2

wants to merge 7 commits into from

Conversation

sergoss
Copy link
Owner

@sergoss sergoss commented Aug 6, 2018

Create pull request for 3 HW

sergoss added 4 commits August 5, 2018 15:30
Settings menu links
Add product to catalog page
Update CSS file for catalog
@@ -18,7 +18,7 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t
}

protected void processRequest(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
request.setAttribute("title", "main");
request.setAttribute("title", "Main");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лучше использовать константы

sergoss added 3 commits August 8, 2018 21:03
Add product to catalog page
Update CSS file for catalog
Create ProductDAO class
Create ProductContract class
@@ -0,0 +1,4 @@
package ru.mikhalev.enterprise.controller;

public class CategoryController {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отсутсвует реализация в контроллере

@@ -0,0 +1,4 @@
package ru.mikhalev.enterprise.controller;

public class OrderConfirmationController {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отсутсвует реализация в контроллере


@ManagedBean
@ViewScoped
public class OrderListController {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отсутсвует реализация в контроллере

@@ -0,0 +1,4 @@
package ru.mikhalev.enterprise.controller;

public class ProductEditController {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отсутсвует реализация в контроллере

import java.util.LinkedHashMap;
import java.util.Map;

public class ProductDAO {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Должна быть аннотация @stateless


import java.util.UUID;

public class ProductEntity implements ProductContract {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Постфикс Entity для сущности ставить не нужно

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants