-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Add quotes to strings #224
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 91.91% 91.90% -0.01%
==========================================
Files 17 17
Lines 1595 1618 +23
==========================================
+ Hits 1466 1487 +21
- Misses 129 131 +2 ☔ View full report in Codecov by Sentry. |
My answers to all three questions:
|
As far as I am concerned, you can get rid of the dot! But I would still wrap strings (and paths!) in quotes, because the user needs to be able to distinguish " " and "" (or "foo " and "foo"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thanks ❤️ |
See #222
To-do
Test output on terminal
Questions
.
at the end? (If there is a validator message, it will take care of prepending.
)std::quoted
also escapes quote inside strings. Do we want that?