-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] A partitioned HIBF layout. #230
Draft
smehringer
wants to merge
30
commits into
seqan:main
Choose a base branch
from
smehringer:phib_by_user_bin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smehringer
force-pushed
the
phib_by_user_bin
branch
from
November 9, 2023 09:22
c1ac1a5
to
b4dc08a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
===========================================
- Coverage 95.74% 79.42% -16.33%
===========================================
Files 19 19
Lines 729 904 +175
===========================================
+ Hits 698 718 +20
- Misses 31 186 +155 ☔ View full report in Codecov by Sentry. |
smehringer
force-pushed
the
phib_by_user_bin
branch
from
November 9, 2023 09:55
900e75c
to
1f66869
Compare
eseiler
force-pushed
the
phib_by_user_bin
branch
from
November 17, 2023 11:11
e62c393
to
6d1fe08
Compare
smehringer
force-pushed
the
phib_by_user_bin
branch
from
January 9, 2024 11:22
95a1b9f
to
eeee4be
Compare
…improve user bin distribution across partitions.
…, choosing best-p by subsumption ratio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a work in progress.
Design decision on how to partition
[NO] Partitioning by k-mer suffix/prefix
This means that each partition will get a sub-content of each user bin, and each partition will be built on every user bin.
Disadvantages:
Advantages:
[NO] Partitioning by IBF (subtree) or The Lazy HIBF
This means that there is still one big HIBF and its individual IBFs or subtrees of IBFs are the partitions.
Disadvantages:
Advantages:
[YES] Partitioning by user bin
This means each partition will index a subset of the user bins, each with an individual layout.
Disadvantages:
Advantages:
Goals for partitioning
What goals do we have (top-down by priority):
The main challenge is: how to assign user bins to partitions?
Possible solutions