Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support evalscriptUrl in BYOCLayer #286

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Better support evalscriptUrl in BYOCLayer #286

wants to merge 1 commit into from

Conversation

zcernigoj
Copy link
Collaborator

@zcernigoj zcernigoj commented Nov 18, 2024 •
edited
Loading

Call fetchEvalscriptUrlIfNeeded in BYOCLayer.getMap(), same as in AbstractSentinelHubV3Layer, so that when only an evalscriptUrl is provided to the BYOCLayer.getMap(), it gets the evalscript automatically.

This is useful for BYOC for visualizations with long evalscripts.

Next step is to improve supportsApiType() function in AbstractSentinelHubV3Layer.ts and BYOCLayer.ts to allow ProcessAPI when evalscriptUrl is provided instead of evalscript. And add this support for getStats() as well.

@zcernigoj zcernigoj marked this pull request as draft November 18, 2024 16:13
@zcernigoj zcernigoj changed the title call fetchEvalscriptUrlIfNeeded in BYOCLayer.getMap() Better support evalscriptUrl in BYOCLayer Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zcernigoj