Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store exception traceback in logs f pipeline fails #331

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

zigaLuksic
Copy link
Collaborator

The finally clause kicks in even if another exception is raised in the except clause

any improvement suggestions are welcome

@zigaLuksic zigaLuksic requested a review from mlubej March 8, 2024 13:20
@zigaLuksic
Copy link
Collaborator Author

we could also just log the traceback, but it seemed better to put it into a separate file

Copy link
Contributor

@mlubej mlubej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good, no comments

@zigaLuksic zigaLuksic merged commit f905255 into develop Mar 8, 2024
7 checks passed
@zigaLuksic zigaLuksic deleted the log-exceptions branch March 8, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants