Add gotenberg output filename #137
Conversation
StevenRenaux
requested review from
Neirda24 and
Jean-Beru
and removed request for
Neirda24
| @@ -69,6 +70,10 @@ protected function encodeData(string $key, mixed $value): array | |||
| */ | |||
| public function fileName(string $fileName, string $headerDisposition = HeaderUtils::DISPOSITION_INLINE): static | |||
| { | |||
| if (!preg_match('/\.[^.]+$/', $fileName)) { | |||
| throw new InvalidBuilderConfiguration(\sprintf('File name "%s" needs to get extension as ".pdf", ".png" or any other valid extension.', $fileName)); | |||
There was a problem hiding this comment.
actually no. Because whatever we do Gotenberg will add the extension.
There was a problem hiding this comment.
yeah but needed with extension I think for the processor :
There was a problem hiding this comment.
normally we guess the filename from the response. Maybe there are some edge cases @Jean-Beru ?
There was a problem hiding this comment.
We can extract the filename from the response to pass it to the processor constructor. But it means that the request will be sent before calling GotenbergFileResult::process or GotenbergFileResult::stream to retrieve headers.
An other solution could be that a processor doesn't receive the filename in its constructor. It will have to retrieve it by itself from a chunk.
There was a problem hiding this comment.
I need to dig a bit to understand more.
StevenRenaux
force-pushed
the
features/Add-Gotenberg-Output-Filename-if-fileName-is-set
branch
from
0b321da to
f247756
Compare
StevenRenaux
force-pushed
the
features/Add-Gotenberg-Output-Filename-if-fileName-is-set
branch
from
f247756 to
3944a70
Compare
Close #91