Merge pull request #109 from sendsmaily/release/2.7.3

Release 2.7.3
sendsmaily · May 6, 2024 · aed9da1 · aed9da1
2 parents 329c447 + 31e325e
commit aed9da1
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+### 2.7.3
+
+- Fixes non-existing array key warning on subscribers synchronization [[#108](https://github.com/sendsmaily/smaily-magento-extension/pull/108)] (thanks @raulikesvatera)
+
 ### 2.7.2
 
 - PHP 8.2 compatibility [[#103](https://github.com/sendsmaily/smaily-magento-extension/pull/103)]

diff --git a/Cron/SubscribersSync.php b/Cron/SubscribersSync.php
@@ -249,7 +249,7 @@ protected function optOutNewsletterSubscribers(\Magento\Store\Api\Data\WebsiteIn
 
             $smailyUnsubscribers = [];
             foreach ($unsubscribers as $unsubscriber) {
-                $email = $unsubscriber['email'];
+                $email = strtolower($unsubscriber['email']);
                 $unsubscribedAt = new \DateTimeImmutable($unsubscriber['unsubscribed_at'], $timezoneLocal);
 
                 $smailyUnsubscribers[$email] = $unsubscribedAt->setTimezone($timezoneUTC);
@@ -268,7 +268,7 @@ protected function optOutNewsletterSubscribers(\Magento\Store\Api\Data\WebsiteIn
             $subscribers = $this->resourceConnection->fetchAll($select);
 
             foreach ($subscribers as $subscriber) {
-                $emailAddress = $subscriber['subscriber_email'];
+                $emailAddress = strtolower($subscriber['subscriber_email']);
                 $changeStatusAt = new \DateTimeImmutable($subscriber['change_status_at'], $timezoneUTC);
                 $unsubscribedAt = $smailyUnsubscribers[$emailAddress];
 

diff --git a/Setup/Patch/Data/NormalizeSyncUnsubscribeStatus.php b/Setup/Patch/Data/NormalizeSyncUnsubscribeStatus.php
@@ -15,7 +15,7 @@ class NormalizeSyncUnsubscribeStatus implements \Magento\Framework\Setup\Patch\D
      */
     public function __construct(
         \Magento\Framework\Setup\ModuleDataSetupInterface $moduleDataSetup,
-        \Magento\Newsletter\Model\ResourceModel\Subscriber\Collection $newsletterSubscribersCollection,
+        \Magento\Newsletter\Model\ResourceModel\Subscriber\Collection $newsletterSubscribersCollection
     ) {
         $this->moduleDataSetup = $moduleDataSetup;
 

diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
     "name": "smaily/smailyformagento",
     "description": "Smaily extension for Magento 2",
-    "version": "2.7.2",
+    "version": "2.7.3",
     "type": "magento2-module",
     "license": "GPL-3.0-only",
     "authors": [

diff --git a/etc/module.xml b/etc/module.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="Smaily_SmailyForMagento" setup_version="2.7.2">
+    <module name="Smaily_SmailyForMagento" setup_version="2.7.3">
         <sequence>
             <module name="Magento_Newsletter" />
             <module name="Magento_Captcha" />