[CLNP-6072] useConnectionHandler #1291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HoonBaek
reviewed
Jan 2, 2025
src/hooks/useConnectionHandler.ts
Outdated
| import { ConnectionHandler, ConnectionState } from '@sendbird/chat'; | ||
| import useSendbirdStateContext from './useSendbirdStateContext' | ||
| import uuidv4 from '../utils/uuid'; | ||
|
|
There was a problem hiding this comment.
may need to export the ConnectionHandler from UIKit, here
export ConnectionHandlerhttps://github.com/sendbird/sendbird-uikit-react/pulls?q=is%3Apr+is%3Aclosed+export+Handlers+thorough
예전에 @sendbird/chat의 인터페이스를 그대로 사용하던 고객에게서 Invalid Parameter Error가 발생한다는 이슈 리포트가 있었습니다. 좀 오래 되어서, 잘 기억은 안나지만 아마도 chat-js와 uikit의 디펜던시로 가지고 있는 chat-js간의 버전이 달라서 발생했던 이슈로 기억합니다. 해당 이슈가 발생할 수 있을지 검토가 필요해 보입니다.
There was a problem hiding this comment.
There was a problem hiding this comment.
ConnectionHandler의 경우에는 v4 초반부터 있었던 핸들러이고 변경 내용이 거의 없어서 괜찮지 않을까 싶긴 한데 그래도 안전빵으로 바꿔두었습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sendbird.atlassian.net/browse/SBISSUE-18182
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.This is a reminder of what we look for before merging your code.
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can set up a CLA to allow for the contribution.