Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RTL QA #213

Merged
merged 7 commits into from
Nov 21, 2024
Merged

fix: RTL QA #213

merged 7 commits into from
Nov 21, 2024

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Nov 4, 2024

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

Description Of Changes

Add a brief description of the changes that you have involved in this PR

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.

Project coverage is 11.54%. Comparing base (9c558e9) to head (58f2d92).

Files with missing lines Patch % Lines
...ges/uikit-react-native/src/libs/MentionManager.tsx 0.00% 4 Missing ⚠️
packages/uikit-utils/src/shared/rtl.ts 42.85% 4 Missing ⚠️
...tive-foundation/src/components/TextInput/index.tsx 0.00% 3 Missing ⚠️
...c/components/ThreadParentMessageRenderer/index.tsx 0.00% 3 Missing ⚠️
...ct-native-foundation/src/components/Text/index.tsx 0.00% 2 Missing ⚠️
...c/components/GroupChannelMessageRenderer/index.tsx 0.00% 1 Missing ⚠️
...MessageRenderer/ThreadParentMessage.file.voice.tsx 0.00% 1 Missing ⚠️
...ative/src/fragments/createGroupChannelFragment.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           feat/rtl     #213      +/-   ##
============================================
+ Coverage     11.49%   11.54%   +0.04%     
============================================
  Files           357      357              
  Lines          8448     8455       +7     
  Branches       2370     2375       +5     
============================================
+ Hits            971      976       +5     
- Misses         7401     7403       +2     
  Partials         76       76              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bang9 bang9 changed the base branch from main to feat/rtl November 4, 2024 12:20
@bang9 bang9 self-assigned this Nov 4, 2024
@bang9 bang9 requested a review from OnestarLee November 21, 2024 05:26
Copy link
Collaborator

@OnestarLee OnestarLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bang9 bang9 merged commit 290758e into feat/rtl Nov 21, 2024
10 checks passed
@bang9 bang9 deleted the fix/rtl-qa branch November 21, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants