Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update openURL logic #167

Merged
merged 1 commit into from
Mar 26, 2024
Merged

chore: update openURL logic #167

merged 1 commit into from
Mar 26, 2024

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Mar 16, 2024

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[TICKET_ID]

Description Of Changes

Add a brief description of the changes that you have involved in this PR

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

Reflect changes of sendbird/sendbird-uikit-react#907

@bang9 bang9 self-assigned this Mar 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 13.00%. Comparing base (e8c2a86) to head (c1e3399).

Files Patch % Lines
packages/uikit-react-native/src/libs/SBUUtils.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   13.00%   13.00%   -0.01%     
==========================================
  Files         334      334              
  Lines        7434     7436       +2     
  Branches     2052     2052              
==========================================
  Hits          967      967              
- Misses       6396     6398       +2     
  Partials       71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bang9 bang9 merged commit 7486041 into main Mar 26, 2024
6 checks passed
@bang9 bang9 deleted the fix/openURL branch March 26, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants