Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLNP-2540): add disableFastImage prop to Image component #166

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Mar 13, 2024

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

CLNP-2540

Description Of Changes

Add a brief description of the changes that you have involved in this PR

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

Usage

import { Image } from '@sendbird/uikit-react-native-foundation';

// If you don't want to use FastImage in UIKit for React Native, you can specify this default prop
if (Image.defaultProps) Image.defaultProps.disableFastImage = true;

@bang9 bang9 self-assigned this Mar 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 13.01%. Comparing base (aabc6d6) to head (b1384bb).

Files Patch % Lines
...oundation/src/components/Image/Image.fastimage.tsx 0.00% 4 Missing ⚠️
...ct-native-foundation/src/components/Image/index.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   13.02%   13.01%   -0.02%     
==========================================
  Files         334      334              
  Lines        7424     7430       +6     
  Branches     2047     2050       +3     
==========================================
  Hits          967      967              
- Misses       6386     6392       +6     
  Partials       71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@HoonBaek HoonBaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bang9 bang9 merged commit c55aba7 into main Mar 14, 2024
6 checks passed
@bang9 bang9 deleted the feat/disable-fast-image-option branch March 14, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants