Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CLNP-2179): introduced new list query params #161

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Feb 2, 2024

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

CLNP-2179

Description Of Changes

  • Add messageListQueryParams to GroupChannelFragment.
  • Add channelListQueryParams to GroupChannelListFragment.
  • Deprecate the collectionCreator prop from GroupChannelFragment and GroupChannelListFragment.
  • Deprecate the use of useGroupChannelList in uikit-chat-hooks.
  • Fix Fragment types for finding the correct props place in the IDE.

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 requested a review from HoonBaek February 2, 2024 03:33
@bang9 bang9 self-assigned this Feb 2, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (58c79b3) 13.04% compared to head (ea06673) 13.02%.

Files Patch % Lines
...e/src/fragments/createGroupChannelListFragment.tsx 0.00% 7 Missing ⚠️
...ative/src/fragments/createGroupChannelFragment.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
- Coverage   13.04%   13.02%   -0.02%     
==========================================
  Files         334      334              
  Lines        7414     7424      +10     
  Branches     2045     2047       +2     
==========================================
  Hits          967      967              
- Misses       6376     6386      +10     
  Partials       71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@HoonBaek HoonBaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bang9 bang9 changed the title chore: introduced new list query params chore(CLNP-2179): introduced new list query params Feb 2, 2024
@bang9 bang9 merged commit a0f48aa into main Feb 2, 2024
6 checks passed
@bang9 bang9 deleted the chore/new-list-params branch February 2, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants