Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CLNP-1564): add promise polyfill for hermes #150

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Nov 20, 2023

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

CLNP-1564

Description Of Changes

  • Add Promise.allSettled polyfill for hermes environment.

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 self-assigned this Nov 20, 2023
@bang9 bang9 requested a review from AhyoungRyu November 20, 2023 08:55
@bang9 bang9 changed the title fix(CLNP-1564): add promise polyfills for hermes fix(CLNP-1564): add promise polyfill for hermes Nov 21, 2023
Copy link

@liamcho liamcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bang9 bang9 merged commit 991bfa5 into main Nov 21, 2023
6 checks passed
@bang9 bang9 deleted the fix/promise-allSettled branch November 21, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants