Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(CLNP-1434): update macos intel to m1 #145

Merged
merged 7 commits into from
Nov 10, 2023
Merged

ci(CLNP-1434): update macos intel to m1 #145

merged 7 commits into from
Nov 10, 2023

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Nov 7, 2023

For Internal Contributors

CLNP-1434

Description Of Changes

background: https://discuss.circleci.com/t/macos-intel-support-deprecation-in-january-2024/48718

@bang9 bang9 self-assigned this Nov 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96ec469) 13.02% compared to head (62a3992) 13.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   13.02%   13.02%           
=======================================
  Files         328      328           
  Lines        7238     7238           
  Branches     2001     2001           
=======================================
  Hits          943      943           
  Misses       6225     6225           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bang9 bang9 force-pushed the ci/migarte-macos branch 2 times, most recently from 8f42870 to b17f795 Compare November 9, 2023 03:03
Copy link

@liamcho liamcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bang9 bang9 merged commit c83e2b4 into main Nov 10, 2023
7 checks passed
@bang9 bang9 deleted the ci/migarte-macos branch November 10, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants