Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci/cd): update firebase app distribution groups #140

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Oct 10, 2023

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[TICKET_ID]

Description Of Changes

  • Add external group to firebase app distribution groups (for QE team)

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 self-assigned this Oct 10, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (71a5b95) 14.43% compared to head (e3ed538) 14.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   14.43%   14.43%           
=======================================
  Files         317      317           
  Lines        6496     6496           
  Branches     1826     1826           
=======================================
  Hits          938      938           
  Misses       5487     5487           
  Partials       71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bang9 bang9 requested a review from a team October 10, 2023 11:34
@bang9 bang9 force-pushed the chore/firebase-dist-groups branch from e3ed538 to 16491ff Compare October 12, 2023 17:56
@bang9 bang9 merged commit 9c0a3f5 into main Oct 12, 2023
1 check passed
@bang9 bang9 deleted the chore/firebase-dist-groups branch October 12, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants