Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CLNP-1100): filter deactivated users when making mention suggestions #136

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Sep 25, 2023

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

CLNP-1100

Description Of Changes

Add a brief description of the changes that you have involved in this PR

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 self-assigned this Sep 25, 2023
@bang9 bang9 force-pushed the fix/mention-deactivated-user branch from 6ebc1d1 to ee1e9c2 Compare September 25, 2023 08:55
@bang9 bang9 requested review from chrisallo and HoonBaek September 25, 2023 08:55
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (16d76ad) 14.44% compared to head (ee1e9c2) 14.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   14.44%   14.43%   -0.01%     
==========================================
  Files         317      317              
  Lines        6495     6496       +1     
  Branches     1825     1826       +1     
==========================================
  Hits          938      938              
- Misses       5486     5487       +1     
  Partials       71       71              
Files Changed Coverage Δ
...kit-react-native/src/hooks/useMentionSuggestion.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bang9 bang9 merged commit 03b3333 into main Sep 26, 2023
@bang9 bang9 deleted the fix/mention-deactivated-user branch September 26, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants