Merge pull request #206 from sendbird/chore/remove-allSettled

chore: remove Promise.allSettled
sendbird · Oct 22, 2024 · c0e94a2 · c0e94a2
2 parents 7513d04 + 631077d
commit c0e94a2
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 8 deletions.
diff --git a/packages/uikit-react-native/src/components/ChannelInput/SendInput.tsx b/packages/uikit-react-native/src/components/ChannelInput/SendInput.tsx
@@ -216,7 +216,8 @@ const SendInput = forwardRef<RNTextInput, SendInputProps>(function SendInput(
             onClose={onClose}
             onDismiss={() => {
               onDismiss();
-              Promise.allSettled([playerService.reset(), recorderService.reset()]);
+              playerService.reset().catch(() => {});
+              recorderService.reset().catch(() => {});
             }}
             backgroundStyle={{ justifyContent: 'flex-end' }}
             visible={voiceMessageInputVisible}

diff --git a/packages/uikit-react-native/src/contexts/PlatformServiceCtx.tsx b/packages/uikit-react-native/src/contexts/PlatformServiceCtx.tsx
@@ -31,7 +31,8 @@ export const PlatformServiceProvider = ({ children, voiceMessageConfig, ...servi
 
   useAppState('change', (state) => {
     if (state !== 'active') {
-      Promise.allSettled([services.playerService.reset(), services.recorderService.reset()]);
+      services.playerService.reset().catch(() => {});
+      services.recorderService.reset().catch(() => {});
     }
   });
 

diff --git a/packages/uikit-react-native/src/fragments/createGroupChannelFragment.tsx b/packages/uikit-react-native/src/fragments/createGroupChannelFragment.tsx
@@ -116,8 +116,9 @@ const createGroupChannelFragment = (initModule?: Partial<GroupChannelModule>): G
       startingPoint: internalSearchItem?.startingPoint,
     });
 
-    const onBlurFragment = () => {
-      return Promise.allSettled([playerService.reset(), recorderService.reset()]);
+    const onBlurFragment = async () => {
+      await playerService.reset().catch(() => {});
+      await recorderService.reset().catch(() => {});
     };
     const _onPressHeaderLeft = useFreshCallback(async () => {
       voiceMessageStatusManager.clear();

diff --git a/packages/uikit-react-native/src/fragments/createGroupChannelThreadFragment.tsx b/packages/uikit-react-native/src/fragments/createGroupChannelThreadFragment.tsx
@@ -103,8 +103,9 @@ const createGroupChannelThreadFragment = (
       startingPoint,
     });
 
-    const onBlurFragment = () => {
-      return Promise.allSettled([playerService.reset(), recorderService.reset()]);
+    const onBlurFragment = async () => {
+      await playerService.reset().catch(() => {});
+      await recorderService.reset().catch(() => {});
     };
     const _onPressHeaderLeft = useFreshCallback(async () => {
       await onBlurFragment();

diff --git a/packages/uikit-react-native/src/hooks/useConnection.ts b/packages/uikit-react-native/src/hooks/useConnection.ts
@@ -52,7 +52,10 @@ const useConnection = () => {
           });
         }
 
-        await Promise.allSettled([initEmoji(sdk, emojiManager), initDashboardConfigs(sdk)]);
+        await Promise.all([
+          initEmoji(sdk, emojiManager).catch(() => Logger.info('[useConnection]', 'initEmoji failure')),
+          initDashboardConfigs(sdk).catch(() => Logger.info('[useConnection]', 'initDashboardConfigs failure')),
+        ]);
 
         Logger.debug('[useConnection]', 'connected! (online)');
         setCurrentUser(user);
@@ -67,7 +70,10 @@ const useConnection = () => {
             Logger.warn('[useConnection]', 'clear cached-data');
             await sdk.clearCachedData().catch((e) => Logger.warn('[useConnection]', 'clear cached-data failure', e));
           } else if (sdk.currentUser) {
-            await Promise.allSettled([initEmoji(sdk, emojiManager), initDashboardConfigs(sdk)]);
+            await Promise.all([
+              initEmoji(sdk, emojiManager).catch(() => Logger.info('[useConnection]', 'initEmoji failure')),
+              initDashboardConfigs(sdk).catch(() => Logger.info('[useConnection]', 'initDashboardConfigs failure')),
+            ]);
 
             Logger.debug('[useConnection]', 'connected! (offline)');
             setCurrentUser(sdk.currentUser);