Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(circuits): set static version of circom #874

Merged
merged 3 commits into from
Oct 16, 2024
Merged

ci(circuits): set static version of circom #874

merged 3 commits into from
Oct 16, 2024

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented Oct 16, 2024 •
edited
Loading

Description

This PR replaces the latest version of Circom in the CI workflows with a static one, in order to avoid breaking the configuration with unexpected changes from the latest version.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cedoor cedoor changed the title fix(circuits): add override for circom_runtime ci(circuits): set static version of circom Oct 16, 2024
@cedoor cedoor marked this pull request as ready for review October 16, 2024 09:58
@cedoor cedoor requested a review from a team as a code owner October 16, 2024 09:58
@cedoor cedoor merged commit cd6dc38 into main Oct 16, 2024
5 checks passed
@cedoor cedoor deleted the ci/print-debug branch October 16, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vplasencia vplasencia vplasencia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cedoor @vplasencia