Merge pull request #26 from elminson/elminson/fixing_empty_string

Add validation for empty or non-numeric RNC input string
seisigmasrl · May 16, 2024 · 144c12b · 144c12b
2 parents 86bad0a + e9bfdf1
commit 144c12b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/DgiiRncValidator.php b/src/DgiiRncValidator.php
@@ -16,6 +16,11 @@ class DgiiRncValidator
     public static function validateRNC(string $string): bool
     {
         $cleanedId = Utils::getNumbers($string);
+
+		if (!$cleanedId) {
+			return false;
+		}
+
         preg_match('/^(\d{9}|\d{11})$/', $cleanedId, $matches);
 
         return (bool) count($matches);

diff --git a/tests/DgiiRncValidatorTest.php b/tests/DgiiRncValidatorTest.php
@@ -28,3 +28,12 @@
         ->and(DgiiRncValidator::check('123456789'))
         ->toBeFalse();
 });
+
+test('check if the given string without numbers is a valid RNC', function () {
+	$id = 'abc cdd';
+	expect(DgiiRncValidator::validateRNC($id))->toBeFalse();
+	$id = ' ';
+	expect(DgiiRncValidator::validateRNC($id))->toBeFalse();
+	$id = '';
+	expect(DgiiRncValidator::validateRNC($id))->toBeFalse();
+});