feat(proxy-sigv4-backend): add region and service options #19
Conversation
|
Thanks for the contribution @jsecchiero! This looks great to me, though the build is failing for |
|
done! |
There was a problem hiding this comment.
Looks like some extra files were added in the latest commit, do you mind removing those to avoid any confusion?
Also, we do need to update the actual config.d.ts file for the new service and region configuration, I missed that initially (my bad)
There was a problem hiding this comment.
did you mean to commit this?
There was a problem hiding this comment.
no i just used it locally and added it erroneously in the last rebase, sorry!
removed now
There was a problem hiding this comment.
did you mean to commit this?
| | { | ||
| /** | ||
| * Target of the proxy. Url string to be parsed with the url module. | ||
| */ | ||
| target: string; | ||
| /** | ||
| * Use credentials for this IAM Role ARN via STS:AssumeRole call when signing the request. | ||
| */ | ||
| roleArn?: string; | ||
| /** | ||
| * Use this session name when performing the STS:AssumeRole call for roleArn. Default: 'tempAssumeRoleSession'. | ||
| */ | ||
| roleSessionName?: string; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
I'm not sure we want to be adding the pkg directory here, but this does remind me that we should be updating the actual config.d.ts file for these new options, sorry for the late catch!
jsecchiero
force-pushed
the
main
branch
2 times, most recently
from
826b695
to
3d2dc97
Compare
|
If we can update the config.d.ts file for the new config options, then this is good to go! Thanks |
Signed-off-by: jsecchiero <[email protected]>
|
done! |
expose region and service from aws4, reference to that options here
example: