[Google Ads] Send non-American country codes correctly #2688
+46
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2688 +/- ##
==========================================
- Coverage 78.52% 78.46% -0.06%
==========================================
Files 1032 1033 +1
Lines 18632 18704 +72
Branches 3530 3549 +19
==========================================
+ Hits 14630 14677 +47
- Misses 2823 2837 +14
- Partials 1179 1190 +11 ☔ View full report in Codecov by Sentry. |
nick-Ag
changed the title
… numbers. The other country code field is for use with addresses
nick-Ag
changed the title
| const formatPhone = (phone: string): string => { | ||
| const formattedPhone = formatToE164(phone, '1') | ||
| const formatPhone = (phone: string, countryCode?: string): string => { | ||
| const formattedPhone = formatToE164(phone, countryCode ?? '+1') |
There was a problem hiding this comment.
Nice, keeping that original default so we don't break current implementations that may depend on it.
maryamsharif
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment Google Ads will always automatically prepend phone numbers with '+1'. This behavior is documented in this ticket: https://segment.atlassian.net/browse/STRATCONN-5386
This PR updates the phone number formatting logic to use the new
phone_country_codefield when formatting a phone number. This field is distinct from the existingcountry_codefield, which expects non-numeric values such as 'US'.Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Tested successfully in local + staging.
Local Test: The phone number is correctly formatted as
payload.phone_country_code + payload.phone.This value is hashed before sending so manually console.logging it before that:
Stage Test
Syncs continue to succeed after the new country code field is introduced and mapped to: