Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing pre-hashed emails for Criteo Audiences. #2681

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seg-leonelsanches
Copy link
Contributor

Some of our customers want to send a pre-hashed email in their events. This PR allows that.

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.51%. Comparing base (8239ea5) to head (7816437).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ations/criteo-audiences/addUserToAudience/index.ts 75.00% 0 Missing and 1 partial ⚠️
...s/criteo-audiences/removeUserFromAudience/index.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2681      +/-   ##
==========================================
- Coverage   78.52%   78.51%   -0.01%     
==========================================
  Files        1032     1032              
  Lines       18632    18630       -2     
  Branches     3530     3530              
==========================================
- Hits        14630    14628       -2     
  Misses       2823     2823              
  Partials     1179     1179              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants