RFC: Try to remove ESLint languageOptions
#1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have more modern defaults specified in `eslint-config-seek/base`. - https://github.com/seek-oss/eslint-config-seek/blob/b06e07d6370c5a0bd585a6dc30ffd7708ff68e06/base.js#L120-L121 - https://github.com/seek-oss/eslint-config-seek/blob/b06e07d6370c5a0bd585a6dc30ffd7708ff68e06/base.js#L138-L141 This may require some manual testing to ensure it doesn't break things on a typical back-end repository that still uses CommonJS.
🦋 Changeset detectedLatest commit: 5c95416 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I gave this a whirl on a few repos (one with a package, one with Lambda functions, one service monorepo) and it seems fine 🤷 |
zbrydon
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have more modern defaults specified in
eslint-config-seek/base.This may require some manual testing to ensure it doesn't break things on a typical back-end repository that still uses CommonJS.