.trim() & it.each

seek-oss · Jan 15, 2025 · 45f800a · 45f800a
1 parent c771121
commit 45f800a
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 29 deletions.
diff --git a/src/cli/migrate/nodeVersion/index.test.ts b/src/cli/migrate/nodeVersion/index.test.ts
@@ -212,32 +212,39 @@ describe('nodeVersionMigration', () => {
 });
 
 describe('getNodeTypesVersion', () => {
-  it('finds the latest node22 types version', () => {
-    jest
-      .spyOn(getNode22TypesVersionModule, 'getNode22TypesVersion')
-      .mockReturnValue('"22.10.6"');
-    const { version, err } = getNode22TypeVersion(22, '22.9.0');
-    expect(version).toBe('22.10.6');
-    expect(err).toBeUndefined();
-  });
-
-  it('defaults to 22.9.0 if the exec returns an invalid version', () => {
-    jest
-      .spyOn(getNode22TypesVersionModule, 'getNode22TypesVersion')
-      .mockReturnValue('This is not a version');
-    const { version, err } = getNode22TypeVersion(22, '22.9.0');
-    expect(version).toBe('22.9.0');
-    expect(err).toBe('Failed to fetch latest version, using fallback version');
-  });
-
-  it('defaults to 22.9.0 if the exec fails', () => {
-    jest
-      .spyOn(getNode22TypesVersionModule, 'getNode22TypesVersion')
-      .mockReturnValue(
-        new Error('Failed to fetch latest version') as unknown as string,
-      );
-    const { version, err } = getNode22TypeVersion(22, '22.9.0');
-    expect(version).toBe('22.9.0');
-    expect(err).toBe('Failed to fetch latest version, using fallback version');
-  });
+  it.each([
+    {
+      mockReturnValue: `"22.10.6"`,
+      expectedVersion: '22.10.6',
+      expectedError: undefined,
+    },
+    {
+      mockReturnValue: `"22.10.6"
+`,
+      expectedVersion: '22.10.6',
+      expectedError: undefined,
+    },
+    {
+      mockReturnValue: 'This is not a version',
+      expectedVersion: '22.9.0',
+      expectedError: 'Failed to fetch latest version, using fallback version',
+    },
+    {
+      mockReturnValue: new Error(
+        'Failed to fetch latest version',
+      ) as unknown as string,
+      expectedVersion: '22.9.0',
+      expectedError: 'Failed to fetch latest version, using fallback version',
+    },
+  ])(
+    'finds the latest node22 types version with mock return value $mockReturnValue',
+    ({ mockReturnValue, expectedVersion, expectedError }) => {
+      jest
+        .spyOn(getNode22TypesVersionModule, 'getNode22TypesVersion')
+        .mockReturnValue(mockReturnValue);
+      const { version, err } = getNode22TypeVersion(22, '22.9.0');
+      expect(version).toBe(expectedVersion);
+      expect(err).toBe(expectedError);
+    },
+  );
 });
diff --git a/src/cli/migrate/nodeVersion/index.ts b/src/cli/migrate/nodeVersion/index.ts
@@ -42,7 +42,8 @@ export const getNode22TypeVersion = (
     }
     const sanitizedVersion = version
       .replace(versionRegex, '$1')
-      .replace(/"/g, '');
+      .replace(/"/g, '')
+      .trim();
     return {
       version: sanitizedVersion,
       err: undefined,