Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lib] Add DNS query for request send #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KernelErr
Copy link

Signed-off-by: KernelErr [email protected]

@KernelErr
Copy link
Author

Seems that GitHub actions are not enabled due to the fork. We may need to enable it.

@KernelErr KernelErr marked this pull request as ready for review February 17, 2022 08:34
@L-jasmine
Copy link
Collaborator

@KernelErr can you fix those like request::get with request:send?

@L-jasmine
Copy link
Collaborator

Wasmedge wasi have a bug in getAddrInfo.

@KernelErr
Copy link
Author

In wasmedge_wasi_socket, Inet4's value is 0, Inet6's value is 1.

https://github.com/KernelErr/wasmedge_wasi_socket/blob/7358ee128285cd8307342777298a1935780f3010/src/lib.rs#L166-L171

@L-jasmine
Copy link
Collaborator

L-jasmine commented Feb 25, 2022

In wasmedge_wasi_socket, Inet4's value is 0, Inet6's value is 1.

https://github.com/KernelErr/wasmedge_wasi_socket/blob/7358ee128285cd8307342777298a1935780f3010/src/lib.rs#L166-L171

Yes. But wasmedge wasi getAddrInfo not transform it.
if ipv4, wasmedge-wasi will return AF_INET(2) , not 0.

@KernelErr
Copy link
Author

In wasmedge_wasi_socket, Inet4's value is 0, Inet6's value is 1.
https://github.com/KernelErr/wasmedge_wasi_socket/blob/7358ee128285cd8307342777298a1935780f3010/src/lib.rs#L166-L171

Yes. But wasmedge wasi getAddrInfo not transform it. if ipv4, wasmedge-wasi will return AF_INET(2) , not 0.

So if I should wait for WasmEdge to fix it. Or change the code in wasmedge_wasi_socket?

@L-jasmine
Copy link
Collaborator

Wait WasmEdge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants