Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "enable enumerator unit tests for linux" #4190

Closed
wants to merge 1 commit into from

Conversation

polybassa
Copy link
Contributor

@polybassa polybassa commented Nov 20, 2023

This reverts commit ef1875a.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #4190 (8a976cf) into master (ef1875a) will decrease coverage by 0.23%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4190      +/-   ##
==========================================
- Coverage   81.94%   81.71%   -0.23%     
==========================================
  Files         331      331              
  Lines       76624    76624              
==========================================
- Hits        62791    62615     -176     
- Misses      13833    14009     +176     

see 16 files with indirect coverage changes

@guedou
Copy link
Member

guedou commented Nov 21, 2023

Should I merge this?

@polybassa
Copy link
Contributor Author

In my opinion, no. I just accidentally pushed to master. So if you are OK with the change on master, it doesn't need to be reverted.

@polybassa
Copy link
Contributor Author

Sorry that this happened! I was trying code-spaces the first time and "clicked" on the wrong button. Which makes me think if we need more restrictive rules to protect the master branch

@polybassa polybassa closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants