Type hint arch/bpf #3825
Merged
Type hint arch/bpf #3825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3825 +/- ##
==========================================
- Coverage 81.95% 81.25% -0.70%
==========================================
Files 331 331
Lines 76647 76654 +7
==========================================
- Hits 62813 62284 -529
- Misses 13834 14370 +536
|
gpotter2
force-pushed
the
macos
branch
2 times, most recently
from
9b42cb8 to
14176fd
Compare
|
This should have been merged a year ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
arch/bpf-> core fully typedThis will not make it into 2.5.0 but was technically ready before 2.5.0 so the claim that we typed the core is valid 😋