Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors notification bar #77

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Refactors notification bar #77

wants to merge 2 commits into from

Conversation

kierangillen
Copy link
Contributor

@kierangillen kierangillen commented Sep 14, 2021 •
edited
Loading

  • Refactors notification bar to leverage context provider. We can now reliably use show from the useNotificationBar provider to know whether or not the bar is visible. Therefore we can add padding behind the nav bar.
  • We can now use the addNofificationData from the provider from anywhere in the clients to create dynamic banners

Screen Shot 2021-09-14 at 2 17 51 PM

@kierangillen kierangillen requested review from l2succes and frahman5 and removed request for l2succes September 14, 2021 13:19
@kierangillen kierangillen marked this pull request as draft September 14, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kierangillen