Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move chairs to last col in summit programs #367

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Move chairs to last col in summit programs #367

merged 2 commits into from
Jun 11, 2024

Conversation

bbrcknl
Copy link
Collaborator

@bbrcknl bbrcknl commented Jun 6, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Preview your changes here

The link checker found some issues!

Running 3 checks (Scripts, Links, Images) in ["_site"] on *.html files...


Checking 350 external links
Checking 519 internal links
Checking internal link hashes in 14 files
Ran on 58 files!


For the Links > External check, the following failures were found:

* At _site/Foundation/Board/index.html:260:

  External link https://www.linkedin.com/in/matthew-p-grosvenor-855a2228/ failed (status code 429)

* At _site/Foundation/Summit/2024/index.html:332:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/Foundation/Summit/2024/index.html:336:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/news/2024.html:457:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/news/2024.html:461:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/news/index.html:456:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/news/index.html:460:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)


HTML-Proofer found 7 failures!
make: *** [Makefile:54: checklinks] Error 1

@bbrcknl bbrcknl changed the title Move session changes to last col in summit programs Move chairs to last col in summit programs Jun 6, 2024
@bbrcknl bbrcknl requested a review from june-andronick June 6, 2024 06:40
june-andronick
june-andronick approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@june-andronick june-andronick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the link errors were temporary. They seem to work for me now. The gitlint error is because the commit title is too long. Else looks good to me, thanks for doing it!

@bbrcknl bbrcknl marked this pull request as ready for review June 11, 2024 20:57
@github-actions GitHub Actions
Copy link

Preview your changes here

@bbrcknl bbrcknl force-pushed the move_chair_column_summit_programs branch from b2d8bf8 to 006050e Compare June 11, 2024 21:03
@github-actions GitHub Actions
Copy link

Preview your changes here

@github-actions GitHub Actions
Copy link

Preview your changes here

The link checker found some issues!

Running 3 checks (Scripts, Links, Images) in ["_site"] on *.html files...


Checking 350 external links
Checking 519 internal links
Checking internal link hashes in 14 files
Ran on 58 files!


For the Links > External check, the following failures were found:

* At _site/Foundation/Board/index.html:288:

  External link https://www.linkedin.com/in/qiyan-wang-8b0b2145/ failed (status code 429)

* At _site/Foundation/Summit/2022/index.html:349:

  External link https://www.linkedin.com/in/axelheider failed (status code 429)

* At _site/Foundation/Summit/2022/index.html:352:

  External link https://www.linkedin.com/in/axelheider failed (status code 429)

* At _site/Foundation/Summit/2023/index.html:386:

  External link https://www.linkedin.com/in/axelheider failed (status code 429)

* At _site/Foundation/Summit/2023/index.html:389:

  External link https://www.linkedin.com/in/axelheider failed (status code 429)

* At _site/Foundation/Summit/2024/index.html:332:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/Foundation/Summit/2024/index.html:336:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/Foundation/Summit/2024/index.html:342:

  External link https://www.linkedin.com/in/mbrcknl/ failed (status code 429)

* At _site/Foundation/Summit/2024/index.html:345:

  External link https://www.linkedin.com/in/mbrcknl/ failed (status code 429)

* At _site/news/2023.html:833:

  External link https://www.linkedin.com/in/axelheider failed (status code 429)

* At _site/news/2023.html:836:

  External link https://www.linkedin.com/in/axelheider failed (status code 429)

* At _site/news/2024.html:457:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/news/2024.html:461:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/news/2024.html:467:

  External link https://www.linkedin.com/in/mbrcknl/ failed (status code 429)

* At _site/news/2024.html:470:

  External link https://www.linkedin.com/in/mbrcknl/ failed (status code 429)

* At _site/news/index.html:456:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/news/index.html:460:

  External link https://www.linkedin.com/in/lucy-parker-13a484253/ failed (status code 429)

* At _site/news/index.html:466:

  External link https://www.linkedin.com/in/mbrcknl/ failed (status code 429)

* At _site/news/index.html:469:

  External link https://www.linkedin.com/in/mbrcknl/ failed (status code 429)


HTML-Proofer found 19 failures!
make: *** [Makefile:54: checklinks] Error 1

@bbrcknl bbrcknl merged commit b3317ad into master Jun 11, 2024
8 of 9 checks passed
@bbrcknl bbrcknl deleted the move_chair_column_summit_programs branch June 11, 2024 21:11
bbrcknl added a commit that referenced this pull request Jun 12, 2024
@bbrcknl
Move chairs to last col in summit prog (#367)
7c95bfc 
Merging even though there are link checker errors. These seem to be external (LinkedIn). The actual links work when clicking on them.
Signed-off-by: Birgit Brecknell <[email protected]>
bbrcknl added a commit that referenced this pull request Jun 14, 2024
@bbrcknl
Move chairs to last col in summit prog (#367)
e6c9715 
Merging even though there are link checker errors. These seem to be external (LinkedIn). The actual links work when clicking on them.
Signed-off-by: Birgit Brecknell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@june-andronick june-andronick june-andronick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbrcknl @june-andronick