Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Announce keynotes #366

Merged
merged 17 commits into from
Jun 12, 2024
Merged

Announce keynotes #366

merged 17 commits into from
Jun 12, 2024

Conversation

bbrcknl
Copy link
Collaborator

@bbrcknl bbrcknl commented Jun 6, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Preview your changes here

The link checker found some issues!

Running 3 checks (Scripts, Links, Images) in ["_site"] on *.html files...


Checking 351 external links
Checking 525 internal links
Checking internal link hashes in 15 files
Ran on 59 files!


For the Links > Internal check, the following failures were found:

* At _site/Foundation/Summit/2024/index.html:239:

  internally linking to abstracts2024#a-; the file exists, but the hash 'a-' does not

* At _site/news/2024.html:138:

  internally linking to ../Foundation/Summit/2024/abstracts2024.html#a-; the file exists, but the hash 'a-' does not

* At _site/news/2024.html:157:

  internally linking to abstracts2024#a-inspecta, which does not exist

* At _site/news/2024.html:172:

  internally linking to abstracts2024#a-, which does not exist

* At _site/news/index.html:137:

  internally linking to ../Foundation/Summit/2024/abstracts2024.html#a-; the file exists, but the hash 'a-' does not

* At _site/news/index.html:156:

  internally linking to abstracts2024#a-inspecta, which does not exist

* At _site/news/index.html:171:

  internally linking to abstracts2024#a-, which does not exist


HTML-Proofer found 7 failures!
make: *** [Makefile:54: checklinks] Error 1

The HTML5 validator found some issues!

Error: End tag for  "body" seen, but there were unclosed elements.
From line 643, column 1; to line 643, column 7 in resource file:_site/news/index.html
Error: Unclosed element "div".
From line 36, column 3; to line 36, column 27 in resource file:_site/news/index.html
Error: End tag for  "body" seen, but there were unclosed elements.
From line 644, column 1; to line 644, column 7 in resource file:_site/news/2024.html
Error: Unclosed element "div".
From line 36, column 3; to line 36, column 27 in resource file:_site/news/2024.html
Document checking completed.

@bbrcknl
add missing div
b51f08f 
Signed-off-by: Birgit Brecknell <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Preview your changes here

The link checker found some issues!

Running 3 checks (Scripts, Links, Images) in ["_site"] on *.html files...


Checking 351 external links
Checking 525 internal links
Checking internal link hashes in 15 files
Ran on 59 files!


For the Links > Internal check, the following failures were found:

* At _site/Foundation/Summit/2024/index.html:239:

  internally linking to abstracts2024#a-; the file exists, but the hash 'a-' does not

* At _site/news/2024.html:138:

  internally linking to ../Foundation/Summit/2024/abstracts2024.html#a-; the file exists, but the hash 'a-' does not

* At _site/news/2024.html:157:

  internally linking to abstracts2024#a-inspecta, which does not exist

* At _site/news/2024.html:172:

  internally linking to abstracts2024#a-, which does not exist

* At _site/news/index.html:137:

  internally linking to ../Foundation/Summit/2024/abstracts2024.html#a-; the file exists, but the hash 'a-' does not

* At _site/news/index.html:156:

  internally linking to abstracts2024#a-inspecta, which does not exist

* At _site/news/index.html:171:

  internally linking to abstracts2024#a-, which does not exist


HTML-Proofer found 7 failures!
make: *** [Makefile:54: checklinks] Error 1

@bbrcknl
fix inspecta abstract link
2da5086 
Signed-off-by: Birgit Brecknell <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Preview your changes here

The link checker found some issues!

Running 3 checks (Scripts, Links, Images) in ["_site"] on *.html files...


Checking 351 external links
Checking 527 internal links
Checking internal link hashes in 15 files
Ran on 59 files!


For the Links > Internal check, the following failures were found:

* At _site/Foundation/Summit/2024/index.html:239:

  internally linking to abstracts2024#a-; the file exists, but the hash 'a-' does not

* At _site/news/2024.html:138:

  internally linking to ../Foundation/Summit/2024/abstracts2024.html#a-; the file exists, but the hash 'a-' does not

* At _site/news/2024.html:172:

  internally linking to ../Foundation/Summit/2024/abstracts2024#a-; the file exists, but the hash 'a-' does not

* At _site/news/index.html:137:

  internally linking to ../Foundation/Summit/2024/abstracts2024.html#a-; the file exists, but the hash 'a-' does not

* At _site/news/index.html:171:

  internally linking to ../Foundation/Summit/2024/abstracts2024#a-; the file exists, but the hash 'a-' does not


HTML-Proofer found 5 failures!
make: *** [Makefile:54: checklinks] Error 1

june-andronick
june-andronick approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@june-andronick june-andronick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the status so far, just a couple of suggestions.

news/2024.html Outdated
<div>
<div class="row" style="margin-left:0px; margin-right:0px">
<p>
We are pleased to announce that the two keynotes for the <a href="../Foundation/Summit/2024">seL4 summit 2024</a> will be <strong>Darren Cofer from Collins Aerospace</strong> and <strong>Ning Qu from
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest Darren Cofer from Collins Aerospace
and add a link to Darren's page/linkedIn from his name, and a link to Collins Aerospace from the company name.
Same for Ning and NIO.

news/2024.html Outdated
<div class="speaker_title" style="text-align:center">
<strong>Darren Cofer</strong>
<br>
Collins Aerospace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again (if easy), I would have a link from Darren's picture and name to his page/linkedIn and a link from Collins Aerospace to the company's website.

Same for Ning/NIO

_includes/abstracts/2024/inspecta.html
</p>
<p class="summit-abstract-author">
Presented by Darren Cofer, <span class="summit-abstract-affiliation">Collins Aerospace</span>
</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments below. Here again, you could have links from Darren's name to his page/linkedIn and from Collins to the company's website (at least for the keynotes, but could be for all the ones we have later)

bbrcknl and others added 11 commits June 12, 2024 15:50
@bbrcknl
add link to LF summit pages (#364)
dedd1a6 
Signed-off-by: Birgit Brecknell <[email protected]>
@lsf37 @bbrcknl
README: improve rbenv install instructions
782dfe4 
- fix typos
- link to homebrew

Signed-off-by: Gerwin Klein <[email protected]>
@seL4-ci @bbrcknl
CI: update performance results
c39ff52 
Signed-off-by: seL4 CI <[email protected]>
@seL4-ci @bbrcknl
CI: update performance results
5927431 
Signed-off-by: seL4 CI <[email protected]>
@bbrcknl
Move chairs to last col in summit prog (#367)
7c95bfc 
Merging even though there are link checker errors. These seem to be external (LinkedIn). The actual links work when clicking on them.
Signed-off-by: Birgit Brecknell <[email protected]>
@bbrcknl
add Ning's abstract
fabbe28 
Signed-off-by: Birgit Brecknell <[email protected]>
@bbrcknl
add keynote speaker pics
13a2e3b 
Signed-off-by: Birgit Brecknell <[email protected]>
@bbrcknl
update keynote grid css
6826861 
Signed-off-by: Birgit Brecknell <[email protected]>
@bbrcknl
center keynote grid
51da0f5 
Signed-off-by: Birgit Brecknell <[email protected]>
@bbrcknl
center keynote grid
44ff3cc 
Signed-off-by: Birgit Brecknell <[email protected]>
@bbrcknl
finalise keynote news announcement
debc973 
Signed-off-by: Birgit Brecknell <[email protected]>
@github-actions GitHub Actions
Copy link

Preview your changes here

The link checker found some issues!

Running 3 checks (Scripts, Links, Images) in ["_site"] on *.html files...


Checking 355 external links
Checking 525 internal links
Checking internal link hashes in 15 files
Ran on 59 files!


For the Links > External check, the following failures were found:

* At _site/Foundation/Board/index.html:188:

  External link https://rtx.com failed (status code 403)

* At _site/Foundation/Membership/index.html:240:

  External link https://www.rtx.com failed (status code 403)

* At _site/news/2021.html:248:

  External link https://www.rtx.com/ failed (status code 403)

* At _site/news/2021.html:1344:

  External link https://www.rtx.com/ failed (status code 403)

* At _site/news/2021.html:1351:

  External link https://www.rtx.com/ failed (status code 403)

* At _site/news/2023.html:481:

  External link https://www.rtx.com failed (status code 403)


HTML-Proofer found 6 failures!
make: *** [Makefile:54: checklinks] Error 1

The HTML5 validator found some issues!

Error: End tag for  "body" seen, but there were unclosed elements.
From line 612, column 1; to line 612, column 7 in resource file:_site/news/index.html
Error: Unclosed element "div".
From line 36, column 3; to line 36, column 27 in resource file:_site/news/index.html
Error: End tag for  "body" seen, but there were unclosed elements.
From line 613, column 1; to line 613, column 7 in resource file:_site/news/2024.html
Error: Unclosed element "div".
From line 36, column 3; to line 36, column 27 in resource file:_site/news/2024.html
Document checking completed.

@bbrcknl
close div in news
d946568 
Signed-off-by: Birgit Brecknell <[email protected]>
@github-actions GitHub Actions
Copy link

Preview your changes here

The link checker found some issues!

Running 3 checks (Scripts, Links, Images) in ["_site"] on *.html files...


Checking 355 external links
Checking 525 internal links
Checking internal link hashes in 15 files
Ran on 59 files!


For the Links > External check, the following failures were found:

* At _site/Foundation/Board/index.html:188:

  External link https://rtx.com failed (status code 403)

* At _site/Foundation/Membership/index.html:240:

  External link https://www.rtx.com failed (status code 403)

* At _site/news/2021.html:248:

  External link https://www.rtx.com/ failed (status code 403)

* At _site/news/2021.html:1344:

  External link https://www.rtx.com/ failed (status code 403)

* At _site/news/2021.html:1351:

  External link https://www.rtx.com/ failed (status code 403)

* At _site/news/2023.html:481:

  External link https://www.rtx.com failed (status code 403)


HTML-Proofer found 6 failures!
make: *** [Makefile:54: checklinks] Error 1

@bbrcknl bbrcknl marked this pull request as ready for review June 12, 2024 07:32
@github-actions GitHub Actions
Copy link

Preview your changes here

@bbrcknl bbrcknl merged commit f3cf786 into master Jun 12, 2024
8 of 9 checks passed
@bbrcknl bbrcknl deleted the announce_keynotes branch June 12, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@june-andronick june-andronick june-andronick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bbrcknl @june-andronick @lsf37 @seL4-ci