-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aarch64 crefine: update to match other arches #744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could use more informative commit message (the "as part of" of your initial comment); optional.
9d6443a
to
36266eb
Compare
I've updated the commit message but left off the reference to the PR, I didn't think it would be too helpful there. Happy to update again if you disagree and think it would be. |
Cool. I agree with leaving the PR off, but my thought was to add a hint of what this was caused by. I guess a commit reference is good enough if someone's investigating. |
I could do
That's basically pulling in the commit message of 146eaa1, although I'm not sure if it would be enough to save curious people from needing to look more closely at that commit (and its parent, which makes the |
I'd be happy with that, but also happy to follow whatever @Xaphiosis decides. |
This corresponds to a change made in 146eaa1, following adjustments to some no_fail attributes. Signed-off-by: Corey Lewis <[email protected]>
36266eb
to
1e9ce18
Compare
This was a change made in 146eaa1, as part of #696.