Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that umm_types.txt is saved relative to theory file. #674

Merged
merged 2 commits into from
Jan 27, 2024

Conversation

adbrucker
Copy link
Contributor

This change ensures that the file "umm_types.txt" is written in the same directory the theory file containing the "install_C_file" Isar command. Otherwise, the file might be written into current working directory of Isabelle, which might not be writable by the user.

Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one also makes sense, thank you.

Can you please add a sign-off line to the commit message for the Developer Certificate of Origin?

@lsf37
Copy link
Member

lsf37 commented Jan 17, 2024

@adbrucker ping -- without the sign-off I can't merge your PR.

@adbrucker adbrucker force-pushed the umm_types_relative branch 2 times, most recently from 1dafe82 to 76dbb29 Compare January 22, 2024 19:10
@lsf37 lsf37 self-assigned this Jan 27, 2024
@lsf37 lsf37 added the C-parser anything about the C/Simpl parser label Jan 27, 2024
@lsf37 lsf37 force-pushed the umm_types_relative branch from 76dbb29 to 7b47170 Compare January 27, 2024 07:40
@lsf37
Copy link
Member

lsf37 commented Jan 27, 2024

(rebased)

@lsf37 lsf37 merged commit 99c79b5 into seL4:master Jan 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-parser anything about the C/Simpl parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants