#292 extend set method to accept a third positional argument #299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #292
This pull request is for issue #292.
I extend set method to accept a third positional argument.
Purpose of This Change
The primary goal of this change is to enhance the compatibility of the
mock_redis
set
method with theredis-store
set
method. By introducing a third positional argument, we aim to align more closely with theredis-store
implementation, facilitating easier integration and use in environments whereredis-store
is prevalent.Compatibility Concerns with Standard Redis
While the
redis-store
set
method accepts three positional arguments, the standard Redisset
method traditionally takes only two. This discrepancy could raise concerns about compatibility. However, this change ensures that compatibility with the standard Redis API is maintained and verified through existing tests inset_spec.rb
.Before and After the Change
Before
The
set
method inmock_redis
was defined as follows:This definition aligns with the standard Redis API but lacks compatibility with the
redis-store
version.After
The revised
set
method is now defined with an additional third positional argument:This addition enables compatibility with
redis-store
without compromising the existing functionality with standard Redis.