File Browser Control "Get" models and irs buttons with dynamic clear button #549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After taking on ToneHunt support I've found NAM newbies often download this plugin but struggle to figure out how to get models. While users like Robert (screenshot below) will do the research or ask in the FB group, I believe a much larger group quietly gives up and leaves NAM for good. I’ve seen this firsthand with several friends I’ve introduced to NAM. To address this issue, this PR adds "Get" buttons to the File Browser Control. These buttons only appear when the File Browser state is empty, replacing the unneeded/redundant "Clear" buttons. The "Get NAM Models" button deep links to all the NAM models on ToneHunt. The "Get IRs" button deep links to all the IRs on ToneHunt. See video demo below:
get-btns.mov
While I understand the purpose of the NeuralAmpModelerPlugin is primarily to demo the core tech, I think in reality it is actually a well distributed entry point for NAM consumers and therefore IMO this gap in "getting started" should be solved in some way. We are currently working on offering a search API as well as a webview embed integration for plugin makers to allow their users to directly search/download from ToneHunt. However, that approach may be overkill for the philosophy behind this plugin. Here, I tried to solve the issue as dead simple as possible, with very little code to change/maintain and with as little visual footprint as possible.
Examples:
https://youtu.be/wIPoLLDUMlU?t=41 (This YouTube influencer shares his first impression of the NAM plugin, highlighting confusion around finding models. Notably, this is my top result when searching 'Neural Amp Modeler' on YouTube.)
Related Github Issues:
#438
#122
#191
#112
#136
Here are a couple alternative designs we came up with:
https://www.figma.com/design/W0gS44o9rBXhplC77vCeBQ/NAM-Plugin-Options?node-id=0-1&p=f&t=BkqVnupGpgSqfVK7-0
PR Checklist
format.bash
?Unserialization.cpp
.)