Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate visium #3407

Merged
merged 9 commits into from
Dec 19, 2024
Merged

Deprecate visium #3407

merged 9 commits into from
Dec 19, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Dec 17, 2024

  • Release notes not necessary because:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@flying-sheep flying-sheep requested a review from giovp December 17, 2024 15:08
@flying-sheep flying-sheep added this to the 1.11.0 milestone Dec 17, 2024
@flying-sheep flying-sheep marked this pull request as ready for review December 17, 2024 15:30
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.66%. Comparing base (1cd5a00) to head (6f91b2b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3407   +/-   ##
=======================================
  Coverage   76.65%   76.66%           
=======================================
  Files         112      112           
  Lines       12931    12935    +4     
=======================================
+ Hits         9912     9916    +4     
  Misses       3019     3019           
Files with missing lines Coverage Δ
src/scanpy/datasets/_datasets.py 100.00% <100.00%> (ø)
src/scanpy/plotting/_tools/scatterplots.py 86.75% <100.00%> (+0.06%) ⬆️
src/scanpy/readwrite.py 76.88% <100.00%> (+0.05%) ⬆️

@flying-sheep flying-sheep enabled auto-merge (squash) December 19, 2024 17:26
@flying-sheep flying-sheep merged commit ac4c629 into main Dec 19, 2024
13 of 14 checks passed
@flying-sheep flying-sheep deleted the pa/deprecate-visium branch December 19, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate/remove read spatial and plotting spatial from scanpy.
1 participant