Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preprecossing/_qc.py:describe_var #3398

Closed
wants to merge 2 commits into from

Conversation

WeilerP
Copy link
Contributor

@WeilerP WeilerP commented Dec 10, 2024

Description

Use f-strings instead of replace.

  • Release notes not necessary because: Minor change.

Use f-strings instead of replace.
@WeilerP
Copy link
Contributor Author

WeilerP commented Dec 10, 2024

I didn't add any release notes since the change is minor. Let me know if you want me to add some nonetheless.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.58%. Comparing base (ef92866) to head (6be0dbc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3398      +/-   ##
==========================================
- Coverage   76.59%   76.58%   -0.01%     
==========================================
  Files         111      111              
  Lines       12874    12870       -4     
==========================================
- Hits         9861     9857       -4     
  Misses       3013     3013              
Files with missing lines Coverage Δ
src/scanpy/preprocessing/_qc.py 81.81% <100.00%> (-0.41%) ⬇️

@ilan-gold ilan-gold added this to the 1.10.5 milestone Dec 10, 2024
@ilan-gold
Copy link
Contributor

Done in #3325

@ilan-gold ilan-gold closed this Dec 10, 2024
@WeilerP WeilerP deleted the feat/update_describe_var branch December 11, 2024 07:12
@flying-sheep
Copy link
Member

Thanks for the PR! I happened to do the same thing in another PR one week or so earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scanpy.preprocessing.describe_var does not use f-strings
3 participants