-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): elem_mul
64 bit upcast option
#3392
base: main
Are you sure you want to change the base?
Conversation
I'm putting this in scanpy2.0 because this setting should be turned on then |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3392 +/- ##
==========================================
+ Coverage 75.36% 75.38% +0.01%
==========================================
Files 112 112
Lines 13219 13229 +10
==========================================
+ Hits 9963 9973 +10
Misses 3256 3256
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this will just use 64 bits for computation and downcast again after?
I hadn't considered that. There's no downcasting at the moment, it just uses 64 bits for the multiplication. Maybe it should downcast to the original? I could see that being beneficial, but then the question is what do we downcast to? The data type of the right or left matrix? We would have to make this clear in the documentation. |
|
elem_mul
in variance calculation should usefloat64
casting #3127