-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore): run azure on multiple vm images #2976
base: main
Are you sure you want to change the base?
Conversation
ilan-gold
commented
Apr 3, 2024
- Testing for leiden alg with igraph flavor causes out of bounds freezing #2969
- Tests included or not required because:
- Release notes not necessary because:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2976 +/- ##
=======================================
Coverage 75.49% 75.49%
=======================================
Files 116 116
Lines 12911 12911
=======================================
Hits 9747 9747
Misses 3164 3164 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the pearson residual tests, that's an easy fix. np.dtype("int")
is np.int32
on windows, and np.int64
everywhere else. So the tests should just be is np.int64
.
test_leiden_random_state[igraph]
does seem to be showing that the random state is at least acting differently here.
@ivirshup yup, commented that. we need to find someone with a windows machine, I think. |
From discussion at triage/ sprint planning:
|