Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that aggregate is only called on anndata #2950

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

ivirshup
Copy link
Member

  • Release notes not necessary because: Fixing something that never made it to a release

@ivirshup ivirshup added this to the 1.10.0 milestone Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.14%. Comparing base (e6c7251) to head (3633712).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2950      +/-   ##
==========================================
- Coverage   75.48%   73.14%   -2.35%     
==========================================
  Files         116      116              
  Lines       12904    12872      -32     
==========================================
- Hits         9741     9415     -326     
- Misses       3163     3457     +294     
Files Coverage Δ
scanpy/get/_aggregated.py 94.73% <90.00%> (-0.62%) ⬇️

... and 27 files with indirect coverage changes

@ivirshup ivirshup changed the title Check that agggregate is only called on anndata Check that aggregate is only called on anndata Mar 25, 2024
@ivirshup ivirshup enabled auto-merge (squash) March 25, 2024 10:47
@ivirshup ivirshup merged commit 10a51d8 into scverse:main Mar 25, 2024
16 of 17 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Mar 25, 2024
ivirshup added a commit that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return type of aggregate is inconsistent
1 participant