-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix): empty boolean mask on backed sparse matrix #1321
Conversation
blocked by #1320 (comment) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1321 +/- ##
==========================================
- Coverage 85.67% 83.56% -2.11%
==========================================
Files 34 34
Lines 5452 5458 +6
==========================================
- Hits 4671 4561 -110
- Misses 781 897 +116
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Do you still consider this blocked? I think it's fine to assume it acts like you'd expect a numpy array too |
Nope, the issue is filed. You thought it was a bug too so we can't wait for a scipy release over this. |
@ivirshup I would wait for an answer from the scipy people confirming scipy/scipy#19919 (comment) before merging, just to be sure empty array creation is correct. We're so close to confirmation of future behavior that I think it's worth waiting unless we're in a rush, in which case you can merge. |
I think that the array classes in scipy are going to end up returning something with |
…1336) Co-authored-by: Ilan Gold <[email protected]>
SparseDataset
errors out with empty boolean mask #1320