Fix IO error reporting #1273
Merged
Fix IO error reporting #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1273 +/- ##
===========================================
- Coverage 85.26% 52.00% -33.26%
===========================================
Files 34 34
Lines 5421 5432 +11
===========================================
- Hits 4622 2825 -1797
- Misses 799 2607 +1808
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Zethson
reviewed
Dec 26, 2023
Zethson
approved these changes
Jan 2, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/anndata
that referenced
this pull request
Jan 4, 2024
flying-sheep
added a commit
that referenced
this pull request
Jan 4, 2024
Co-authored-by: Philipp A <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so group path reporting in IO errors actually works.
It also fixes
test_only_child_key_reported_on_failure, which did nothing before:re.searchsearches anywhere in the string, so every string can be successfully searched for(?s)((?!Error raised while writing key '/?a').)*$. Only with the^at the start will that regex successfully fail when the substring is contained.