Fix na_action compatibility (#1226)

scverse · Nov 3, 2023 · b97e98f · b97e98f
1 parent a94dfb2
commit b97e98f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/anndata/compat/__init__.py b/anndata/compat/__init__.py
@@ -395,8 +395,8 @@ def _safe_transpose(x):
 
 
 def _map_cat_to_str(cat: pd.Categorical) -> pd.Categorical:
-    if Version(pd.__version__) >= Version("2.0"):
-        # Argument added in pandas 2.0
+    if Version(pd.__version__) >= Version("2.1"):
+        # Argument added in pandas 2.1
         return cat.map(str, na_action="ignore")
     else:
         return cat.map(str)
diff --git a/docs/release-notes/0.10.4.md b/docs/release-notes/0.10.4.md
@@ -2,6 +2,7 @@
 
 ```{rubric} Bugfix
 ```
+* Only try to use `Categorical.map(na_action=…)` in actually supported Pandas ≥2.1 {pr}`1226` {user}`flying-sheep`
 
 ```{rubric} Documentation
 ```
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,7 @@ @@
     ```{rubric} Bugfix
     ```
+    * Only try to use `Categorical.map(na_action=…)` in actually supported Pandas ≥2.1 {pr}`1226` {user}`flying-sheep`
     ```{rubric} Documentation
     ```
@@ Expand Down @@