refactor multiple choice return API - rename answer indexes

scrumdojo · Dec 6, 2024 · 0ffad8d · 0ffad8d
1 parent b99e110
commit 0ffad8d
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/backend/src/main/java/cz/scrumdojo/quizmaster/quiz/MultipleAnswersResult.java b/backend/src/main/java/cz/scrumdojo/quizmaster/quiz/MultipleAnswersResult.java
@@ -11,6 +11,6 @@
 @Builder
 public class MultipleAnswersResult {
     private final Boolean questionAnsweredCorrectly;
-    private final List<Integer> wrongAnswers;
+    private final List<Integer> answersRequiringFeedback;
 
 }
diff --git a/backend/src/main/java/cz/scrumdojo/quizmaster/quiz/QuizQuestion.java b/backend/src/main/java/cz/scrumdojo/quizmaster/quiz/QuizQuestion.java
@@ -40,7 +40,7 @@ public static Function<QuizQuestion, Boolean> isCorrectAnswer(int index) {
             && quizQuestion.getCorrectAnswers()[0] == index;
     }
 
-    public static Function<QuizQuestion, List<Integer>> getWrongAnswers(int[] userAnswers) {
+    public static Function<QuizQuestion, List<Integer>> getWrongAnswersIndexes(int[] userAnswers) {
         return quizQuestion -> {
             int[] correctAnswers = quizQuestion.getCorrectAnswers();
 

diff --git a/backend/src/main/java/cz/scrumdojo/quizmaster/quiz/QuizQuestionController.java b/backend/src/main/java/cz/scrumdojo/quizmaster/quiz/QuizQuestionController.java
@@ -49,15 +49,15 @@ public ResponseEntity<Boolean> answerQuestion(@PathVariable Integer id, @PathVar
     public ResponseEntity<MultipleAnswersResult> answerMultipleChoice(@PathVariable Integer id, @RequestBody List<Integer> answers) {
         int[] answersArray = answers.stream().mapToInt(Integer::intValue).toArray();
 
-        var wrongAnswers = findQuestion(id).map(QuizQuestion.getWrongAnswers(answersArray)).orElse(List.of());
+        var wrongAnswersIndexes = findQuestion(id).map(QuizQuestion.getWrongAnswersIndexes(answersArray)).orElse(List.of());
 
-        var isAnsweredCorrectly = wrongAnswers.isEmpty();
+        var isAnsweredCorrectly = wrongAnswersIndexes.isEmpty();
 
         return response(
             Optional.of(
                 new MultipleAnswersResult(
                     isAnsweredCorrectly,
-                    wrongAnswers
+                    wrongAnswersIndexes
                 )
             )
         );

diff --git a/backend/src/test/java/cz/scrumdojo/quizmaster/quiz/QuizQuestionControllerTest.java b/backend/src/test/java/cz/scrumdojo/quizmaster/quiz/QuizQuestionControllerTest.java
@@ -79,7 +79,7 @@ private void checkMultipleAnswers(List<Integer> userAnswersIndexes, boolean isCo
         assertNotNull(result);
         assertEquals(isCorrect, result.getQuestionAnsweredCorrectly());
 
-        assertEquals(expectedWrongAnswers,result.getWrongAnswers());
+        assertEquals(expectedWrongAnswers,result.getAnswersRequiringFeedback());
     }
 
     @Test

diff --git a/frontend/src/services/QuizQuestionService.ts b/frontend/src/services/QuizQuestionService.ts
@@ -9,7 +9,7 @@ export const isAnswerCorrect = async (questionId: number, answerIdx: number) =>
 
 export type MultipleAnswerResult = {
     questionAnsweredCorrectly: boolean
-    wrongAnswers: number[]
+    answersRequiringFeedback: number[]
 }
 
 export const isMultipleAnswersCorrect = async (questionId: number, answersList: number[]) => {