Skip to content

Commit

Permalink
fix: some normative recommendations (#1547)
Browse files Browse the repository at this point in the history
Co-authored-by: 0xmountaintop <[email protected]>
  • Loading branch information
songzhibin97 and 0xmountaintop authored Nov 11, 2024
1 parent c4ba0f9 commit 3ab5752
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion common/testcontainers/testcontainers.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ func (t *TestcontainerApps) GetL2GethEndPoint() (string, error) {
return endpoint, nil
}

// GetL2GethEndPoint returns the endpoint of the running L2Geth container
// GetWeb3SignerEndpoint returns the endpoint of the running L2Geth container
func (t *TestcontainerApps) GetWeb3SignerEndpoint() (string, error) {
if t.web3SignerContainer == nil || !t.web3SignerContainer.IsRunning() {
return "", errors.New("web3signer is not running")
Expand Down
4 changes: 2 additions & 2 deletions coordinator/internal/types/prover.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ const (
)

// MakeProverType make ProverType from ProofType
func MakeProverType(proof_type message.ProofType) ProverType {
switch proof_type {
func MakeProverType(proofType message.ProofType) ProverType {
switch proofType {
case message.ProofTypeChunk:
return ProverTypeChunk
case message.ProofTypeBatch, message.ProofTypeBundle:
Expand Down
2 changes: 1 addition & 1 deletion rollup/internal/controller/sender/sender.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const (
)

var (
// ErrTooManyPendingBlobTxs
// ErrTooManyPendingBlobTxs error for too many pending blob txs
ErrTooManyPendingBlobTxs = errors.New("the limit of pending blob-carrying transactions has been exceeded")
)

Expand Down
4 changes: 2 additions & 2 deletions rollup/internal/controller/sender/transaction_signer.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ import (
)

const (
// PrivateKeySignerType
// PrivateKeySignerType is the type of signer that uses a private key to sign transactions
PrivateKeySignerType = "PrivateKey"

// RemoteSignerType
// RemoteSignerType is the type of signer that uses a remote signer to sign transactions
RemoteSignerType = "RemoteSigner"
)

Expand Down

0 comments on commit 3ab5752

Please sign in to comment.