Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3200): incorporating selection to render number of historical builds in jobs list view #1291

Merged
merged 8 commits into from
Dec 12, 2024
+12 −2
Merged

feat(3200): incorporating selection to render number of historical builds in jobs list view #1291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ee12060
stage changed components
VonnyJap Dec 6, 2024
b670af3
add filter for jobs
VonnyJap Dec 6, 2024
c2f2e37
fix lint
VonnyJap Dec 9, 2024
eb3b94f
changed the v1 back to previous
VonnyJap Dec 9, 2024
ec417a2
Update app/components/pipeline/jobs/table/component.js
VonnyJap Dec 10, 2024
bb6f625
add history filter for new jobs list view interface
VonnyJap Dec 12, 2024
64d84c4
Update app/components/pipeline/jobs/table/component.js
VonnyJap Dec 12, 2024
852b729
Update app/components/pipeline/jobs/table/dataReloader.js
VonnyJap Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/components/pipeline/jobs/table/component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,14 @@ export default class PipelineJobsTableComponent extends Component {
},
{
title: 'HISTORY',
propertyName: 'history',
className: 'history-column',
component: 'historyCell'
component: 'historyCell',
filterFunction: async (_, filterVal) => {
await this.dataReloader.setNumBuilds(filterVal);
},
filterWithSelect: true,
predefinedFilterOptions: ['5', '10', '15', '20', '25', '30']
},
{
title: 'DURATION',
Expand Down
6 changes: 5 additions & 1 deletion app/components/pipeline/jobs/table/dataReloader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,12 @@ export default class DataReloader {
});
}

setNumBuilds(numBuilds) {
async setNumBuilds(numBuilds) {
if (this.numBuilds === numBuilds) {
return;
}
this.numBuilds = numBuilds;
await this.fetchBuildsForJobs(this.jobIdsMatchingFilter);
}

start() {
Expand Down