feat: add event card to new ui #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adong
force-pushed
the
adong/newui-eventcard
branch
from
579ebd9 to
2e14b43
Compare
minghay
requested changes
May 21, 2024
| import Route from '@ember/routing/route'; | ||
| import { inject as service } from '@ember/service'; |
There was a problem hiding this comment.
Suggested change
| import { inject as service } from '@ember/service'; | |
| import { service } from '@ember/service'; |
Comment on lines
+9
to
+12
| const eventId = | ||
| get(model, 'events.firstObject.id') === undefined | ||
| ? 0 | ||
| : get(model, 'events.firstObject.id'); |
There was a problem hiding this comment.
Suggested change
| const eventId = | |
| get(model, 'events.firstObject.id') === undefined | |
| ? 0 | |
| : get(model, 'events.firstObject.id'); | |
| const eventId = model.events.firstObject.id; |
There was a problem hiding this comment.
I made the changes, and it needs to be reverted back. See error
app/v2/pipeline/events/route.js
Outdated
| @@ -1,9 +1,38 @@ | |||
| import Route from '@ember/routing/route'; | |||
| import RSVP from 'rsvp'; | |||
| import { inject as service } from '@ember/service'; | |||
There was a problem hiding this comment.
Suggested change
| import { inject as service } from '@ember/service'; | |
| import { service } from '@ember/service'; |
app/v2/pipeline/events/show/route.js
Outdated
| @@ -1,9 +1,14 @@ | |||
| import Route from '@ember/routing/route'; | |||
| import { inject as service } from '@ember/service'; | |||
There was a problem hiding this comment.
Suggested change
| import { inject as service } from '@ember/service'; | |
| import { service } from '@ember/service'; |
app/v2/pipeline/index/route.js
Outdated
| @@ -1,6 +1,20 @@ | |||
| import Route from '@ember/routing/route'; | |||
| import { inject as service } from '@ember/service'; | |||
There was a problem hiding this comment.
Suggested change
| import { inject as service } from '@ember/service'; | |
| import { service } from '@ember/service'; |
Comment on lines
+65
to
+66
| font-size: 14px; | ||
| font-style: normal; |
There was a problem hiding this comment.
These should safe to remove
Comment on lines
+75
to
+76
| font-style: normal; | ||
| font-weight: 400; |
There was a problem hiding this comment.
These should safe to remove
Comment on lines
6
to
7
| import { Promise as EmberPromise } from 'rsvp'; | ||
| import Service from '@ember/service'; |
There was a problem hiding this comment.
Suggested change
| import { Promise as EmberPromise } from 'rsvp'; | |
| import Service from '@ember/service'; | |
| import sinon from 'sinon'; |
There was a problem hiding this comment.
You'll need to add sinon to the dev dependencies and can also remove ember-sinon
Comment on lines
16
to
27
| const userSettingsStub = Service.extend({ | ||
| getUserPreference() { | ||
| return new EmberPromise(resolve => { | ||
| resolve({ | ||
| timestampFormat: 'UTC' | ||
| }); | ||
| }); | ||
| } | ||
| }); | ||
|
|
||
| this.owner.unregister('service:userSettings'); | ||
| this.owner.register('service:userSettings', userSettingsStub); |
There was a problem hiding this comment.
Suggested change
| const userSettingsStub = Service.extend({ | |
| getUserPreference() { | |
| return new EmberPromise(resolve => { | |
| resolve({ | |
| timestampFormat: 'UTC' | |
| }); | |
| }); | |
| } | |
| }); | |
| this.owner.unregister('service:userSettings'); | |
| this.owner.register('service:userSettings', userSettingsStub); | |
| const userSettings = this.owner.lookup('service:user-settings'); | |
| sinon.stub(userSettings, 'getUserPreference').resolves({timestampFormat: 'UTC'}); |
app/v2/pipeline/index/route.js
Outdated
| beforeModel() { | ||
| const { pipeline } = this.modelFor('v2.pipeline'); | ||
|
|
||
| if (pipeline.get('childPipelines')) { |
There was a problem hiding this comment.
Suggested change
| if (pipeline.get('childPipelines')) { | |
| if (pipeline.childPipelines) { |
minghay
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add event card and meta data info to event card
Objective
Build on top of #1040
Screenshot:
Regular Card
Card with parameters
References
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.