update (#636)

screwdriver-cd · Dec 19, 2024 · c74e3dd · c74e3dd
1 parent cea3593
commit c74e3dd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/lib/helper.js b/lib/helper.js
@@ -267,10 +267,13 @@ async function getManagedBuildClusterName({ annotations, pipeline, isPipelineUpd
     const buildCluster = findBuildCluster(allBuildClusters, buildClusterName, pipeline.scmContext);
 
     if (!buildCluster) {
-        throw new Error(
+        const error = new Error(
             `Cluster specified in screwdriver.cd/buildCluster ${buildClusterName} ` +
                 `for scmContext ${pipeline.scmContext} and group ${groupName} does not exist.`
         );
+
+        error.statusCode = 400;
+        throw error;
     }
 
     if (buildCluster.scmContext !== pipeline.scmContext || !hasClusterAccess(pipeline.name, buildCluster)) {

diff --git a/test/lib/buildFactory.test.js b/test/lib/buildFactory.test.js
@@ -689,6 +689,7 @@ describe('Build Factory', () => {
                         'Cluster specified in screwdriver.cd/buildCluster iOS ' +
                             `for scmContext ${scmContext} and group default does not exist.`
                     );
+                    assert.strictEqual(err.statusCode, 400);
                 });
         });
 

diff --git a/test/lib/pipeline.test.js b/test/lib/pipeline.test.js
@@ -3213,6 +3213,7 @@ describe('Pipeline Model', () => {
                     'Cluster specified in screwdriver.cd/buildCluster iOS ' +
                         `for scmContext ${pipeline.scmContext} and group default does not exist.`
                 );
+                assert.strictEqual(err.statusCode, 400);
             });
         });
-Original file line number
+Diff line change
@@ Expand Up / @@ -689,6 +689,7 @@ describe('Build Factory', () => { @@
                             'Cluster specified in screwdriver.cd/buildCluster iOS ' +
                                 `for scmContext ${scmContext} and group default does not exist.`
                         );
+                        assert.strictEqual(err.statusCode, 400);
                     });
             });
@@ Expand Down @@