Check existence of expression in console endpoint #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, using the `/api/user/console` endpoint and specifying a shard but not an expression resulted in the user being sent a `TypeError` description in the response JSON. Now, the user is told that the expression is invalid. The error expression was chosen to be similar to that for an invalid shard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, using the
/api/user/consoleendpoint and specifying a shard but not an expression resulted in the user being sent aTypeErrordescription in the response JSON. Now, the user is told that the expression is invalid.The error expression was chosen to be similar to that for an invalid shard.