-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace old profiler with new one #61
Conversation
btw, I pulled this change into my fork at https://github.com/KarateSnoopy/screeps-typescript-starter/tree/profiler-merged My changes:
[at-loader] ./src/lib/Profiler/Profiler/Profiler.ts:43:5 This pull request https://github.com/screepers/screeps-typescript-profiler/pull/1/files added this line.
Then I get this error which I can't figure out how to shake. TS1206: Decorators are not valid here. But I can get it working by doing it manually. For example: function mainLoop() { Any idea why |
@KarateSnoopy I haven't tried the typescript profiler, but I'm planning to migrate to it in my primary codebase. @bryanbecker seems to be inactive as of late, so I'll have to figure things out on my own atm. Will let you know if I find anything. Regardless, his work on the new profiler looks promising. I'm considering merging this PR if I could get it to work on my primary codebase. |
@KarateSnoopy Alright, I seem to have found what caused your issues.
As mentioned earlier, I've created a fork to attempt to fix many of the issues found in the profiler, so if you want, you can use that until the upstream is fixed. |
Superseded with future plans of revamping the starter kit. |
This change is probably controversial, so lets hear feedback.
I ripped out the old profiler, and added https://github.com/screepers/screeps-typescript-profiler
It's set up with everything it needs to work, but commented out by default, since the starter doesn't include anything profilable (only classes and class-methods can be profiled).
Also updated the readme to reflect the repo needs to be cloned with
--recursive
tag